Skip to content

Add 'reviewed under 24h' and 'completed under 48h' PR health metrics #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nigusu-Allehu merged 1 commit into from
Jul 21, 2026
Merged

Add 'reviewed under 24h' and 'completed under 48h' PR health metrics #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions NuGetClientPRHealth/DashboardService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,22 @@ private async Task<List<PRRecord>> EnrichAsync(List<RawPR> prs)

private static DashboardMetrics ComputeMetrics(List<PRRecord> prs)
{
if (prs.Count == 0) return new DashboardMetrics(0, 0, 0, 0);
if (prs.Count == 0) return new DashboardMetrics(0, 0, 0, 0, 0, 0);

var sorted = prs.Select(p => p.HoursToMerge).OrderBy(x => x).ToList();
var n = sorted.Count;
var median = n % 2 == 0 ? (sorted[n / 2 - 1] + sorted[n / 2]) / 2.0 : sorted[n / 2];
var reviewed = prs.Where(p => p.FirstApprovalHours.HasValue).ToList();
var approved = prs.Where(p => p.FirstApprovalHours.HasValue).ToList();
var withReview = prs.Where(p => p.FirstReviewHours.HasValue).ToList();

return new DashboardMetrics(
TotalPRs: prs.Count,
MedianHoursToComplete: Math.Round(median, 1),
PercentApprovedUnder24h: reviewed.Count > 0
? Math.Round((double)reviewed.Count(p => p.FirstApprovalHours! < 24) / reviewed.Count * 100, 1) : 0,
PercentMergedUnder24h: Math.Round((double)prs.Count(p => p.HoursToMerge < 24) / prs.Count * 100, 1));
PercentApprovedUnder24h: approved.Count > 0
? Math.Round((double)approved.Count(p => p.FirstApprovalHours! < 24) / approved.Count * 100, 1) : 0,
PercentReviewedUnder24h: withReview.Count > 0
? Math.Round((double)withReview.Count(p => p.FirstReviewHours! < 24) / withReview.Count * 100, 1) : 0,
Comment thread
Nigusu-Allehu marked this conversation as resolved.
PercentMergedUnder24h: Math.Round((double)prs.Count(p => p.HoursToMerge < 24) / prs.Count * 100, 1),
PercentMergedUnder48h: Math.Round((double)prs.Count(p => p.HoursToMerge < 48) / prs.Count * 100, 1));
}
}
2 changes: 2 additions & 0 deletions NuGetClientPRHealth/HtmlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ public static void Generate(DashboardData data, string outputPath)
sb.AppendLine($"<tr><td>Total number of PRs in range</td><td>{data.Metrics.TotalPRs}</td></tr>");
sb.AppendLine($"<tr><td>Median: Hours to complete</td><td>{data.Metrics.MedianHoursToComplete:F1}</td></tr>");
sb.AppendLine($"<tr><td>Percentage of PRs approved under 24 hrs</td><td>{data.Metrics.PercentApprovedUnder24h:F1}%</td></tr>");
sb.AppendLine($"<tr><td>Percentage of PRs reviewed under 24 hrs</td><td>{data.Metrics.PercentReviewedUnder24h:F1}%</td></tr>");
sb.AppendLine($"<tr><td>Percentage of PRs completed under 24 hrs</td><td>{data.Metrics.PercentMergedUnder24h:F1}%</td></tr>");
sb.AppendLine($"<tr><td>Percentage of PRs completed under 48 hrs</td><td>{data.Metrics.PercentMergedUnder48h:F1}%</td></tr>");
sb.AppendLine("</table>");

// Slow PRs
Expand Down
4 changes: 3 additions & 1 deletion NuGetClientPRHealth/Models.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public record DashboardMetrics(
int TotalPRs,
double MedianHoursToComplete,
double PercentApprovedUnder24h,
double PercentMergedUnder24h);
double PercentReviewedUnder24h,
double PercentMergedUnder24h,
double PercentMergedUnder48h);

public record DashboardData(
string DateRange,
Expand Down