Add remote spawns#46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
spawn_onoperator, that sends work to a remote thread using the same underlying queue as broadcasts. This operator is needed for game-engine scheduling, where we want bias the normal amortization/stealing path to eagerly distribute a small number of long-running tasks.I also changed the
SpawnandSpawnScopedtraits to decouple task-type (closure, or async function) from task-scheduling (shared, local, or remote).Every time I do stuff like this, I have to run a full safety audit to ensure all the arguments still work. Usually I find a bunch of places where I can improve the existing safety proofs. This time was no different; I've made a lot of small improvements to safety arguments across the repo, and fixed a few minor things.