mobile: add a theme setting: light, dark, or follow the system - #3136
Merged
Conversation
plugin.theme picks the color scheme, with a live try-before-you-buy selector on the settings page like the accent one; 'system' tracks the device's preference live. Everything themes off Bootstrap's data-bs-theme, with the hardcoded light colors in mobile.css moved to the corresponding CSS variables. The near-black accent would vanish on the dark theme's near-black background, so there it resolves to its counterpart, near-white (it's relabeled "Contrast" to match), with the progress-bar stripes, progress labels and selected-filter text flipping dark to stay legible on the near-white fills. Progress labels also gain a bolder weight across all themes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin.themeoption ('light', 'dark' or 'system') plus a live theme selector on the settings page, working like the existing accent selector: not persisted, a reload reverts to the configured option. 'system' follows the device's light/dark preference live viaprefers-color-scheme.data-bs-theme: the core's Bootstrap 5 assets flip their own components, and the hardcoded light colors in mobile.css move to the corresponding Bootstrap CSS variables.Test plan
Made with Cursor