mobile: don't blank the torrent list when the label panel is incomplete - #3133
Merged
Merged
Conversation
processTorrents() read the desktop categoryList "plabel" panel
unconditionally to build the label filter list. That access threw a
TypeError in two real situations, aborting the function before any row
was rendered and leaving the torrent list blank (the error was swallowed
by the update request's empty error handler):
- the panel is not always populated when the mobile view first paints;
- the "no label" bucket ("-_-_-nlb-_-_-") only exists when at least one
torrent is unlabelled, so it is missing when every torrent has a
label -- a common configuration.
Guard both reads: fall back to a zero "no label" count and skip the
label loop when the panel is absent. When the panel is present the
behaviour is unchanged.
7 tasks
This was referenced Jul 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processTorrents() read the desktop categoryList "plabel" panel unconditionally to build the label filter list. That access threw a TypeError in two real situations, aborting the function before any row was rendered and leaving the torrent list blank (the error was swallowed by the update request's empty error handler):
Guard both reads: fall back to a zero "no label" count and skip the label loop when the panel is absent. When the panel is present the behaviour is unchanged.