[chore] Log generation output buffer size at the start of a training step #1930
Merged
Conversation
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new metric async/gen_buffer_qsize_at_wait_start to track the buffer occupancy when a training step starts waiting for the generation buffer in fully_async_trainer.py. There are no review comments provided, so I have no additional feedback to offer.
eicherseiji
added a commit
to eicherseiji/SkyRL
that referenced
this pull request
Jul 20, 2026
…#1930 Review feedback from SumanthRH. The buffer capacity is a run constant: compute it once in __init__ as the single source for both the queue construction and a one-time skyrl_gen_buffer_maxsize publish, kept for dashboard panels. Drop the per-step W&B keys: NovaSky-AI#1930 already logs async/gen_buffer_qsize_at_wait_start, and this PR keeps only the step-start Prometheus gauge for the depth.
eicherseiji
added a commit
to eicherseiji/SkyRL
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^^