Skip to content

#4291 rules parser updates - #4365

Draft
cielbellerose wants to merge 9 commits into
feature/rules-dashboardfrom
#4291-rules-parser-updates
Draft

#4291 rules parser updates#4365
cielbellerose wants to merge 9 commits into
feature/rules-dashboardfrom
#4291-rules-parser-updates

Conversation

@cielbellerose

@cielbellerose cielbellerose commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Changes

  • FHE now catches subrules with format "(a)" instead of just "a."

  • Removed TOC exclusion, the formatting was just too hard to perfect and I didn't want the chance of excluding any rules. Users now have the option to specify a first page to skip over the beginning pdf sections

  • Removed automatic header/footer exclusion, the logic was too specific/unreliable and risked removing real rule content

Test Cases

Added parsing test coverage!

  • Excluding page number footer tests ('Page 7 of 143' for FSAE, '7' individual numbers for FHE)
  • normalizeContent???
  • findParentRuleCode testing ('EV.5.2.2' -> 'EV.5.2')
  • handleDuplicateCodes adds suffix correctly
  • extractSubRules for a, b, c rules captured only when on new line
  • FSAE and FHE test coverage with real pdf examples

Screenshots

...

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4291

@cielbellerose cielbellerose linked an issue Aug 4, 2026 that may be closed by this pull request
@cielbellerose
cielbellerose changed the base branch from develop to feature/rules-dashboard August 4, 2026 19:37
@cielbellerose cielbellerose self-assigned this Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RulesDashboard] - Update FHE Parser

1 participant