Skip to content

#4343 Expanding a Work Package in Gantt will cause the blocked lines to move as well - #4362

Open
glickgNU wants to merge 2 commits into
developfrom
#4343-gantt-blocked-lines-bug
Open

#4343 Expanding a Work Package in Gantt will cause the blocked lines to move as well#4362
glickgNU wants to merge 2 commits into
developfrom
#4343-gantt-blocked-lines-bug

Conversation

@glickgNU

@glickgNU glickgNU commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Changes

Expanding a Work Package in Gantt will cause the blocked lines to move as well

Notes

Test Cases

  • Expanding and collapsing a work package repeatedly causes the blocked lines to move accordingly

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4343

@staysgt staysgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far! Everything worked functionality wise, just a few cleanups

Comment on lines +44 to +45
const onToggle = editability?.onToggle;
if (!onToggle) throw Error;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If editability isn't passed in this will fail, so we want to just set a fallback of an empty function rather than throwing an error

Comment thread src/frontend/src/pages/GanttPage/GanttChart/GanttChart.tsx Outdated
Comment thread src/frontend/src/pages/GanttPage/GanttChart/GanttChartCollectionSection.tsx Outdated

@staysgt staysgt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maintenance] - Gantt Blocked Lines Bug

2 participants