Nominate @llakala#119
Open
philiptaron wants to merge 1 commit into
Open
Conversation
isabelroses
approved these changes
Jul 7, 2026
mweinelt
approved these changes
Jul 7, 2026
Member
|
Having seen her work over the past several months, cannot agree more that she is well deserving of the commit bit. Always good to see someone working on nixpkgs evaluation time, and she has done an incredible job! |
pyrox0
approved these changes
Jul 7, 2026
ethancedwards8
approved these changes
Jul 7, 2026
GraysonTinker
approved these changes
Jul 7, 2026
GraysonTinker
left a comment
There was a problem hiding this comment.
I've been exceedingly impressed by everything I've seen from her since she started contributing. In no time at all she has proven herself to be incredibly knowledgeable with Nix, and I admire her work in constantly evaluating PRs for their performance implications.
shellhazard
approved these changes
Jul 7, 2026
qweered
approved these changes
Jul 7, 2026
|
It's an honor, thank you! I just took some time to set up commit signing and Bitwarden - I'd love to avoid being the cause of a security vulnerability. Happy to accept this and hopefully unblock some other people's work. |
llakala
approved these changes
Jul 7, 2026
leona-ya
approved these changes
Jul 7, 2026
figsoda
approved these changes
Jul 7, 2026
doronbehar
approved these changes
Jul 8, 2026
aaravrav
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to nominate @llakala (Eman Resu, "user name" backwards) for a nixpkgs commit bit.
Over the last six months, I've watched llakala become one of the most dedicated stewards of
libandstdenvevaluation performance. She has run a sustained, systematic campaign to make nixpkgs evaluation faster, and to make better use of the memory and CPU resources available. This is incremental, careful, painstaking work: hundreds of careful, well-scoped commits that shave allocations and function calls out of the hottest code paths with no regressions to functionality.Here's a representative sample:
lib.lists: performance improvements (#522834) where she rewrotetake,drop,init,flatten,foldl',toposortand friends to avoid unnecessarysublistcalls, subtractions, andbuiltinslookups.lib: removeassertMsg,throwIf, andthrowIfNotusage (#524523) where she removed eagerly-evaluated assertion overhead treewide.lib.strings: small performance cleanups (#519085) andlib.sources: small performance improvements (#536129).ci/eval: add opt-in instruction counting using perf (#538429), where she's starting to build the measurement infrastructure so these wins are verified with reproducible numbers rather than the extremely fuzzy "CPU time" metric. This was the PR where I thought: I should nominate her.Each change is individually small, but collectively they make every
nixevaluation across the entire ecosystem cheaper. It demands a deep understanding of the evaluator's cost model and meticulous care to preserve semantics.Just as important is her sense of ownership. She reviews actively in these areas and keeps the quality bar high, while treating the people who propose changes with dignity and respect.
Thought the total set of commits and reviews are smaller than most we grant the commit bit to, I've seen enough to believe that she'll do good -- and be unblocked and be an unblocker -- with a commit bit. I'd like to see what further good she'll be able to do by hitting merge on the PRs that she reviews.