port: self-update and metrics-gating#2
Merged
Conversation
sheyabernstein
added
bug
syednexgen
reviewed
Jul 3, 2026
syednexgen
left a comment
syednexgen
left a comment
Collaborator
There was a problem hiding this comment.
left a few notes, mostly around self-update safety and rollout behavior.
syednexgen
reviewed
Jul 3, 2026
- TOCTOU: use os.CreateTemp for temp binary to prevent symlink replacement - data-loss: restore from backup on cross-device copy failure in atomicSwap - metrics: MetricsEnabled *bool with nil=enabled; collectors default enabled - refactor hub client 401-retry pattern into doWithKeyRefresh helper - verify digest and resolve symlinks before exec; skip non-semver silently
syednexgen
reviewed
Jul 3, 2026
syednexgen
left a comment
syednexgen
left a comment
Collaborator
There was a problem hiding this comment.
one remaining thing from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port missing agent subsystems: