Skip to content

fix: rename semantic drift to lexical drift, update model names#39

Merged
JNK234 merged 1 commit into
mainfrom
fix/lexical-drift-rename
Mar 19, 2026
Merged

fix: rename semantic drift to lexical drift, update model names#39
JNK234 merged 1 commit into
mainfrom
fix/lexical-drift-rename

Conversation

@JNK234

@JNK234 JNK234 commented Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Renamed all "semantic drift" references to "lexical drift" — Jaccard distance measures vocabulary replacement rate, not semantic similarity
  • Updated hardcoded default models to current versions (gpt-5.4-mini, claude-haiku-4-5-20251001, gemini-2.5-flash)
  • Updated config-multi-provider.txt with current model names and increased max_tokens

Jaccard distance measures vocabulary replacement rate, not semantic
similarity. Renamed all labels and comments accordingly. Updated
hardcoded default models to current versions (gpt-5.4-mini,
claude-haiku-4-5-20251001, gemini-2.5-flash).
@JNK234
JNK234 merged commit 1d2ea47 into main Mar 19, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8bfb5ab7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

# Default provider/model on startup
provider=ollama
model=llama3.2:3b
provider=openai

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep this template from hard-failing without OpenAI keys

Using openai as the active provider breaks the advertised “skip providers that are not ready” flow. setup first does llm:load-config "config-multi-provider.txt" (demos/provider-sensitivity/provider-sensitivity.nlogox:43-57), and LoadConfigCommand aborts if the active provider lacks credentials (src/main/LLMExtension.scala:373-391). That means a user who only fills anthropic_api_key, gemini_api_key, or only has Ollama running never reaches llm:providers; the demo falls back to config instead of using the ready providers from this file. In practice this change makes OpenAI credentials mandatory for a multi-provider template that is supposed to tolerate missing providers.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant