fix(android): mask secure input in BareTextInputRenderer - #54
Open
unlocdavid wants to merge 1 commit into
Open
Conversation
The bare renderer builds its own BasicTextField and never passed visualTransformation, so `secure` parsed but never reached the field and the password rendered in the clear. Outlined and filled already pass it; iOS is unaffected because its bare renderer delegates to NativeUITextInputCore. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android,
securehas no effect on<native:bare-text-input>— the password renders in the clear.BareTextInputRendererbuilds its ownBasicTextFieldand never passesvisualTransformation, so thesecureprop is parsed intoTextInputProps(TextInputShared.kt:112) and mapped toPasswordVisualTransformation()(TextInputShared.kt:75-76), but never reaches the field.Changes
visualTransformation = props.visualTransformationinto theBasicTextFieldconstructor. No new import — the property is already typed onTextInputProps.Notes
OutlinedTextInputRenderer.kt:157,FilledTextInputRenderer.kt:144).NativeUITextInputCore.singleLineto avoid conflicting with that PR.keyboard="password"does not substitute:KeyboardType.Passwordis an IME hint, not a display transform.