Skip to content

feat: implement initial missing functions on main db - #170

Open
mcllerena wants to merge 10 commits into
mainfrom
ml/functions
Open

feat: implement initial missing functions on main db#170
mcllerena wants to merge 10 commits into
mainfrom
ml/functions

Conversation

@mcllerena

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.10924% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.46%. Comparing base (fd605d0) to head (11cea1f).

Files with missing lines Patch % Lines
src/plexosdb/db.py 72.88% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   96.22%   95.46%   -0.76%     
==========================================
  Files          20       20              
  Lines        3151     3244      +93     
==========================================
+ Hits         3032     3097      +65     
- Misses        119      147      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pesap pesap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the inline findings before merging. The update implementation should reuse the existing property validation and membership-resolution paths, and follow the established bulk insertion pattern for batch execution. Keep update_property() as a thin public wrapper; removing the shared helper is not required if it cleanly centralizes the selector logic. Please also add coverage for rollback after domain-validation failures, scenario-scoped updates, explicit parent membership selection, and reusing the connection after a failed batch.

Comment thread src/plexosdb/db.py
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread src/plexosdb/db.py Outdated
Comment thread tests/test_plexosdb_update_property.py
@mcllerena
mcllerena requested a review from pesap August 13, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants