Skip to content

fix: Fix Sienna reserve requirement timeseries scaling - #313

Open
akrivi wants to merge 1 commit into
mainfrom
al/sienna_reserve_requirement
Open

fix: Fix Sienna reserve requirement timeseries scaling#313
akrivi wants to merge 1 commit into
mainfrom
al/sienna_reserve_requirement

Conversation

@akrivi

@akrivi akrivi commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This PR normalizes each ReEDS hourly reserve requirements profile (in MW) by its peak, which preserves the original MW requirements after PowerSystems serialization and ensures PowerSimulations receives the correct non-zero reserve requirements.

@akrivi
akrivi marked this pull request as ready for review August 13, 2026 00:26
@akrivi
akrivi deployed to ci-tests August 13, 2026 00:27 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 00:27 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 00:27 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 00:27 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 00:27 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 00:27 — with GitHub Actions Active
@codecov-commenter

codecov-commenter commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.32%. Comparing base (2af872f) to head (2349a24).

Files with missing lines Patch % Lines
...-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py 90.90% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   85.30%   85.32%   +0.01%     
==========================================
  Files          20       20              
  Lines        5567     5593      +26     
==========================================
+ Hits         4749     4772      +23     
- Misses        818      821       +3     
Files with missing lines Coverage Δ
...s-to-sienna/src/r2x_reeds_to_sienna/translation.py 100.00% <100.00%> (ø)
...-to-sienna/src/r2x_reeds_to_sienna/getter_utils.py 85.10% <90.90%> (+0.62%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akrivi
akrivi force-pushed the al/sienna_reserve_requirement branch from ee0963f to 2349a24 Compare August 13, 2026 02:02
@akrivi
akrivi deployed to ci-tests August 13, 2026 02:03 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 02:03 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 02:03 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 02:03 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 02:03 — with GitHub Actions Active
@akrivi
akrivi deployed to ci-tests August 13, 2026 02:03 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants