Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 84.14% 84.52% +0.38%
==========================================
Files 45 45
Lines 2491 2592 +101
==========================================
+ Hits 2096 2191 +95
- Misses 395 401 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
abdelrahman-ayad
left a comment
There was a problem hiding this comment.
Excellent work Akrivi! I left a couple of very minor comments. Can we also include metrics tests in the test/Results/metrics.jl ?
| using PRASCapacityCredits | ||
| using Literate | ||
|
|
||
| ENV["GKSwstype"] = "100" # Prevent GR from opening gksqt GUI |
| sitename = "PRAS", | ||
| format = Documenter.HTML( | ||
| prettyurls = true, | ||
| prettyurls = haskey(ENV, "GITHUB_ACTIONS"), |
| # `StorageEnergySamples` result specifications instead. | ||
|
|
||
|
|
||
| # ## Export Aggregate Results |
There was a problem hiding this comment.
I'm unsure if we need this here, and would favor the results db/event viewer which will come soon, mainly because we don't expose how this can be read back in or develop tools for down stream analysis with this output.
| @@ -0,0 +1,144 @@ | |||
| # # Interpreting Resource Adequacy Metrics | |||
There was a problem hiding this comment.
I'm wondering if this is an extension to PRAS walkthrough, please give me your thoughts! Can you also include the CVAR here if we go ahead with this? Also will be nice to link this to the docs/resourceadequacy.md page.
There was a problem hiding this comment.
Actually let's keep this here, bring CVAR in. Call this "Multi metric resource adequacy analyses with PRAS"
| # multiple complementary metrics should be considered together to understand | ||
| # the frequency, distribution and severity of shortfall events. | ||
| # ([NERC (2018)](https://www.nerc.com/globalassets/who-we-are/standing-committees/rstc/pawg/probabilistic_adequacy_and_measures_report.pdf), | ||
| # [EPRI](https://www.epri.com/research/products/3002027833), |
There was a problem hiding this comment.
Is it appropriate to cite ESIG report as well - https://www.esig.energy/reports-briefs/new-resource-adequacy-criteria/?
| end No newline at end of file | ||
| end | ||
|
|
||
| """ |
There was a problem hiding this comment.
Let's move this to below NEUE please
| timeunits, powerunits, energyunits, unitsymbol | ||
|
|
||
| import PRASCore.Results: EUE, LOLE, NEUE, ShortfallResult, ShortfallSamplesResult, AbstractShortfallResult, Result | ||
| import PRASCore.Results: EUE, LOLE, NEUE, LOLD, ShortfallResult, ShortfallSamplesResult, AbstractShortfallResult, Result |
There was a problem hiding this comment.
Could you split this into separate lines like the other imports here?
| return size(shortfall.shortfall,3) | ||
| end | ||
|
|
||
| const _lold_warned = Ref(false) |
There was a problem hiding this comment.
I think I'd rather have this passed in as a variable to get_lold_result from the write() function and being tracked there, than this global variable for the function, as this will be set to true once, and then won't be displayed if used in loop (like in the REPL)
This PR:
Loss of Load Days (LOLD)metric as defined in [1]Mathematical formulation
We define the Loss of Load Days (LOLD) metric as:
where:
and
We note that LOLD is not naturally defined at a single timestamp, since it aggregates over all time periods within a day. As a result, additional computation is needed compared to LOLE, namely:
Benchmarks
Complexity wise, the system wide and full-horizon LOLD scales with total simulation size, while the day-specifc queries scale only with the size of the selected day.
We also provide below a comparison of the benchmarks between LOLD and LOLE:

References:
[1] G. Stephen et al., "Clarifying the Interpretation and Use of the LOLE Resource Adequacy Metric," 2022 17th International Conference on Probabilistic Methods Applied to Power Systems (PMAPS), Manchester, United Kingdom, 2022, pp. 1-4, doi: 10.1109/PMAPS53380.2022.9810615.