Skip to content

[Concurrency] Constrain Swift 6 escape hatches #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NachoSoto wants to merge 1 commit into from
Closed

[Concurrency] Constrain Swift 6 escape hatches #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AsyncImageView/AsyncImageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ open class AsyncImageView<

private let imageCreationScheduler: ReactiveSwift.Scheduler

private var disposable: Disposable?
nonisolated(unsafe) private var disposable: Disposable?

public init(
initialFrame: CGRect,
Expand Down
13 changes: 10 additions & 3 deletions AsyncImageView/Renderers/ViewRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ fileprivate func createProducer<Data: RenderDataType>(
renderBlock: @escaping @MainActor (UIView) -> UIImage
) -> SignalProducer<UIImage, Never> {
return SignalProducer { observer, lifetime in
let observer = UncheckedSendableBox(value: observer)
let lifetime = UncheckedSendableBox(value: lifetime)

MainActor.assumeIsolated {
let view = viewCreationBlock(data)
view.frame.origin = .zero
Expand All @@ -98,9 +101,9 @@ fileprivate func createProducer<Data: RenderDataType>(
// We can't take a snapshot right away because the view has not been commited to the render server yet.
UIScheduler().schedule {
MainActor.assumeIsolated {
if !lifetime.hasEnded {
observer.send(value: renderBlock(view))
observer.sendCompleted()
if !lifetime.value.hasEnded {
observer.value.send(value: renderBlock(view))
observer.value.sendCompleted()
}
}
}
Expand All @@ -114,4 +117,8 @@ fileprivate func draw(view: UIView, inContext context: CGContext) {
view.layer.render(in: context)
}

fileprivate struct UncheckedSendableBox<Value>: @unchecked Sendable {
let value: Value
}

#endif
Loading