Qa -> prod electronicResources with multiple URLs fix - #786
Merged
Conversation
danamansana
commented
Jul 23, 2026
danamansana
commented
Contributor
- A small fix that has already been checked in QA for bibs with electronic resources that have multiple urls
- @nonword and @chrismulholland there are some changes from your commits in this PR, affecting scripts and tests. I think these are safe to go to prod but wanted to check with you first. OK to merge?
Adds nyql vs advanced-search api tests
Adds new script for generating documentation based on previously extracted search mappings. Integrates with scripts/build-mappings-document.js (which required a few changes)
Adds boolean search to api tests
…L-api-tests-refactor_PR6
Scc 5452/nyql api tests refactor pr5
Add scritps/build-mappings-document-table.js
Scc 5381
main -> QA split electronicResources
Scc 5452/nyql api tests refactor pr6
chrismulholland
approved these changes
Jul 23, 2026
chrismulholland
left a comment
chrismulholland
left a comment
Contributor
There was a problem hiding this comment.
for my part, it looks like this is just adding in the nyql api tests (not all are included here, and the rest will come later.) So I think it's ok from my end.
Use new QA cluster config
Member
|
My work is safe to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.