main -> qa fix memory leak (?) - #768
Merged
Merged
Conversation
Updates the customer-code discrepancy check, which alerts us to differences between a record's indexed ReCAP customer code and the one returned from SCSB. Now that we're sometimes indexing customer codes with a namespace prefix for disambiguation, given that the SCSB api continues to return not-namespaced values, we should discount the namespace prefix when making the comparison. Also fixes a few tests discovered to be not testing what they purported to test.
…crepancy-error Update customer-code discrepancy check
- Early call to makeNyplDataApiClient - Clear timeout when possible
Add attempt at memory management:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.