Conversation
Contributor
|
Tested it locally and it looks good! Just one small nit and then I can approve |
fatimarahman
approved these changes
Jul 24, 2026
fatimarahman
left a comment
fatimarahman
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this so quickly!
Contributor
|
@nassir-j Actually one quick thing -- can you update the README so the monthly check is included in the list of alarms? Also you should prob update the CHANGELOG to denote you fixed the bug. Sorry v last min requests. Other than those you should be good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the date used in the OverDrive monthly query so that the "end date" ignores the last day, an "exlcusive" query, like the sql used for the redshift queries.