Skip to content

only run monthly check in production #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nassir-j merged 1 commit into from
Jul 15, 2026
Merged

only run monthly check in production #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions alarms/models/overdrive_checkouts_alarms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,23 @@ def run_checks(self):
self.logger.info(f"Checking OD record count from ({self.daily_test_date})...")
self._run_redshift_checks(overdrive_count, monthly_check=False)

# The 'weekday' method returns Thursday as 3 so this check will run every Friday
if self.yesterday_date.weekday() == 3:
try:
self.logger.info(
f"Running weekly check for inconsistencies between overdrive and redshift for the dates between {self.monthly_test_start_date} - {self.daily_test_date}"
)
monthly_overdrive_count = self.overdrive_client.get_count(
self.monthly_test_start_date, self.daily_test_date
)
self._run_redshift_checks(monthly_overdrive_count, monthly_check=True)
except Exception as e:
self.logger.error(f"Failed to scrape OverDrive Marketplace: {e}")
self.overdrive_client.quit_driver()
return
if self.run_added_tests:
# The 'weekday' method returns Thursday as 3 so this check will run every Friday
if self.yesterday_date.weekday() == 3:
try:
self.logger.info(
f"Running weekly check for inconsistencies between overdrive and redshift for the dates between {self.monthly_test_start_date} - {self.daily_test_date}"
)
monthly_overdrive_count = self.overdrive_client.get_count(
self.monthly_test_start_date, self.daily_test_date
)
self._run_redshift_checks(
monthly_overdrive_count, monthly_check=True
)
except Exception as e:
self.logger.error(f"Failed to scrape OverDrive Marketplace: {e}")
self.overdrive_client.quit_driver()
return

self.overdrive_client.quit_driver()
check_no_records_found_alarm(
Expand Down
Loading