Skip to content

fix: slides mode misorders x/y/z slider transforms - #23

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/panda-fk-95714472
Open

fix: slides mode misorders x/y/z slider transforms#23
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/panda-fk-95714472

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Problem

fix: slides mode misorders x/y/z slider transforms

Fix

Replace:

    elif mode == "slides":
        slide_x = e0 @ e1 @ e2 @ e3 @ e4 @ e5 @ e6 @ e7 @ e8 @ e9
        slide_y = e0 @ e1 @ e2 @ e3 @ e4 @ e5 @ e6 @ e7 @ e8 @ e9 @ e10
        slide_z = e0 @ e1 @ e2 @ e3 @ e4 @ e5 @ e6 @ e7 @ e8 @ e9 @ e10 @ e11
        return slide_x, slide_y, slide_z

with:

    elif mode == "slides":
        slide_x = e0 @ e1 @ e2 @ e3 @ e4 @ e5 @ e6 @ e7 @ e8 @ e9 @ e10
        slide_y = e0 @ e1 @ e2 @ e3 @ e4 @ e5 @ e6 @ e7 @ e8 @ e9 @ e10 @ e11
        slide_z = e0 @ e1 @ e2 @ e3 @ e4 @ e5 @ e6 @ e7 @ e8 @ e9 @ e10 @ e11 @ e12
        return slide_x, slide_y, slide_z

Files changed

  • utils/panda_fk.py

Reconstructed from original sweep finding patch(es).
@andrewwhitecdw
andrewwhitecdw force-pushed the bugfix/panda-fk-95714472 branch from 728f36a to f1e9840 Compare August 2, 2026 19:31
@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review August 3, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant