Skip to content

safe strcpy driver root #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rajatchopra wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

safe strcpy driver root #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/driver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/

#include <sys/types.h>

#include <bsd/string.h>
#include <inttypes.h>

#include "nvml.h"
Expand Down Expand Up @@ -89,7 +89,10 @@ driver_init(struct error *err, struct dxcore_context *dxcore, const char *root,
.gid = gid,
.nvml_dl = NULL,
};
strcpy(ctx->root, root);
if (strlcpy(ctx->root, root, sizeof(ctx->root)) >= sizeof(ctx->root)) {
error_setx(err, "root path too long (max %zu bytes)", sizeof(ctx->root) - 1);
goto fail;
}

if (dxcore->initialized) {
memset(ctx->nvml_path, 0, strlen(ctx->nvml_path));
Expand Down
Loading