docs: add GPU support to HCL#4112
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThe HCL documentation now describes support for current NVIDIA data center GPUs, clarifies that platform-specific compatibility is not validated in the HCL, and directs readers to server manufacturers for qualification details. ChangesGPU documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/hcl.md`:
- Around line 65-67: Update the “Last Updated” metadata in the HCL documentation
to reflect the addition of the GPUs section, using the current date of the
change. Leave the GPU support content unchanged.
- Around line 67-73: Clarify the GPU table’s “Supported” scope by renaming the
support column or qualifying the row to explicitly describe NICo/NVIDIA
software-stack support, consistent with the page disclaimer. Replace the
unbounded “Current NVIDIA Data Center GPUs” wording with a release/date anchor
or an explicit supported GPU-family list, while preserving operator-facing
guidance.
- Around line 71-73: Update the GPU support table in the HCL documentation so
the header, separator, and data rows all have leading and trailing pipes,
following the repository’s required MD055 table style.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 323a0571-1cf5-4541-968e-1ad959b705d9
📒 Files selected for processing (1)
docs/hcl.md
polarweasel
left a comment
There was a problem hiding this comment.
Fixed the table for ya
Signed-off-by: Jared Conway <jaredc@nvidia.com>
Co-authored-by: Alex Ball <awball@polarweasel.org> Signed-off-by: jpc204 <50123158+jpc204@users.noreply.github.com>
Co-authored-by: Alex Ball <awball@polarweasel.org> Signed-off-by: jpc204 <50123158+jpc204@users.noreply.github.com>
1245894 to
7bdd0c7
Compare
|
🌿 Preview your docs: https://nvidia-preview-pull-request-4112.docs.buildwithfern.com/infra-controller |
Summary
Impact
Readers can now confirm NICo's general GPU support policy directly in the Hardware Compatibility List while retaining the existing platform-first organization.
Validation
git diff --check