[helm] validate devicePlugin custom configMap settings#2642
Merged
Conversation
tariq1890
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya and
shivamerla
as code owners
July 15, 2026 21:47
|
coverage: 31.812%. remained the same — helm-validate-device-plugin-config into main |
rajathagasthya
approved these changes
Jul 15, 2026
rahulait
reviewed
Jul 16, 2026
rahulait
reviewed
Jul 16, 2026
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
helm-validate-device-plugin-config
branch
from
July 16, 2026 15:39
80ac4c4 to
a35e5f1
Compare
Contributor
Author
|
@rahulait Thanks for the review! Please check now |
tariq1890
enabled auto-merge
July 16, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the rendered device-plugin daemonset ends up in a bad state when the user enables custom configmap creation but provides empty configmap data as input.
Closes #2641