Apply validator resources to init containers#2557
Open
Shivkumar13 wants to merge 1 commit into
Open
Conversation
Shivkumar13
requested review from
cdesiniotis,
karthikvetrivel,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
June 17, 2026 17:40
Signed-off-by: Shivkumar Ople <sople@nvidia.com>
Shivkumar13
force-pushed
the
gh-702-init-container-resources
branch
from
June 17, 2026 18:01
73f0040 to
98cfccd
Compare
Contributor
|
Thanks @Shivkumar13 , the changes look fine to me. We should be doing this for all driver daemonsets managed by gpu-operator. For example, we are still missing requests/limits for k8s-driver-manager init container in driver daemonset. There are few other init containers as well which are also missing requests/limits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #702.
This change applies the existing
spec.validator.resourcessettings to validator init containers as well as the main validator container. The affected init containers run the validator image for driver, toolkit, CUDA, and plugin checks, so using the existing validator resource field keeps the API surface unchanged while making those init containers configurable.Validation:
go test ./controllers -run TestTransformValidatorComponentWithResources -count=1go test ./controllers -run TestTransformValidator -count=1go test ./controllers -run TestTransformSandboxValidator -count=1