Skip to content

Fix triangle_attention custom_vjp fwd/primal pytree mismatch (tuple vs list) #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ssiddhantsharma wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Fix triangle_attention custom_vjp fwd/primal pytree mismatch (tuple vs list) #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cuequivariance_jax/cuequivariance_jax/triangle/_triangle_attention.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,11 @@ def triangle_attention_custom_vjp(
def triangle_attention_custom_vjp_fwd(q, k, v, bias, mask, scale, precision=None):
a, lse, amax = fwd_p.bind(q, k, v, bias, mask, scale=scale, precision=precision)
residuals = (a, lse, q, k, v, bias, mask)
return (a, lse, amax), residuals
# Match the primal output's pytree structure: `triangle_attention_custom_vjp`
# returns `fwd_p.bind(...)`, and a multiple_results primitive's bind returns a
# list. Returning a tuple here trips custom_vjp's fwd/primal structure check
# on JAX versions that enforce exact tuple-vs-list equality (TypeError).
return [a, lse, amax], residuals


def triangle_attention_custom_vjp_bwd(scale, precision, residuals, cotangents):
Expand Down
Loading