Slack perf release - #2545
Conversation
Greptile SummaryThe PR adds Slack publication to the release workflow and addresses the previously reported multiline, dry-run, and duplicate-retry paths. However, the revised request now fails permanently on the first transient HTTP rejection.
|
| Filename | Overview |
|---|---|
| .github/workflows/perform-release.yml | Adds guarded Slack publication and correct JSON serialization, but removes retries even for transient responses that definitively rejected the request. |
Prompt To Fix All With AI
### Issue 1
.github/workflows/perform-release.yml:514
**Transient rejections drop announcements**
When Slack returns a transient response that definitively rejects the request, such as HTTP 429 or 5xx, this single-attempt `curl` command fails the publication step without retrying, leaving the release announcement unpublished even though retrying that response is safe.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (3): Last reviewed commit: "Merge branch 'main' into slack-perf-rele..." | Re-trigger Greptile
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} | ||
| run: | | ||
| payload="$(jq --raw-input --slurp --compact-output '{text: .}' "$RUNNER_TEMP/slack-announcement.txt")" | ||
| curl --fail-with-body \ |
There was a problem hiding this comment.
Transient rejections drop announcements
When Slack returns a transient response that definitively rejects the request, such as HTTP 429 or 5xx, this single-attempt curl command fails the publication step without retrying, leaving the release announcement unpublished even though retrying that response is safe.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/perform-release.yml
Line: 514
Comment:
**Transient rejections drop announcements**
When Slack returns a transient response that definitively rejects the request, such as HTTP 429 or 5xx, this single-attempt `curl` command fails the publication step without retrying, leaving the release announcement unpublished even though retrying that response is safe.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Description
Implemented the Slack publishing step in .github/workflows/perform-release.yml:377.
Validation: YAML parse and git diff --check passed. No docs update was needed; this is an internal release-workflow secret.
Checklist