Require page rendering for page-level image embeddings - #2544
Merged
Conversation
Contributor
Greptile SummaryThe PR automatically enables PDF page rendering when page-level image or text-image embeddings require raster input.
|
| Filename | Overview |
|---|---|
| nemo_retriever/src/nemo_retriever/graph/ingestor_runtime.py | Detects page-level visual embedding modes and enables page-image extraction before constructing direct or auto-dispatch graphs. |
| nemo_retriever/src/nemo_retriever/ingestor/branch_extraction.py | Applies the page-rendering requirement to PDF extraction branches before their outputs enter the shared embedding graph. |
| nemo_retriever/tests/test_ingest_manifest.py | Verifies that mixed PDF and text ingestion enables page rasterization for both visual embedding modalities. |
| nemo_retriever/tests/test_pdf_render_params_wiring.py | Exercises the SDK path and verifies rendered page payloads and embedding vectors are materialized. |
| nemo_retriever/tests/test_pipeline_graph.py | Covers direct PDF, auto-dispatch, visual modality, and text-only graph configuration behavior. |
| docs/docs/extraction/embedding.md | Documents the combined granularity and modality settings required for page-as-image embedding. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Page-level embedding requested] --> B{Modality}
B -->|text| C[Preserve extraction settings]
B -->|image or text_image| D[Enable PDF page rendering]
D --> E[Extract page_image]
E --> F[Shared embedding stage]
F --> G[Rows with image embeddings]
Reviews (2): Last reviewed commit: "Merge branch 'main' into nvbug_6628056" | Re-trigger Greptile
jperez999
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Page-level
imageandtext_imageembedding could silently return PDF page rows without image payloads or embedding vectors whenextract_page_as_imagewas not explicitly enabled.This change treats page rendering as a required extraction step whenever
embed_granularity="page"is combined withembed_modality="image"or"text_image". It applies the behavior consistently across direct PDF graphs, automatic dispatch, and mixed-input manifest branches. Page-level text-only embedding remains unchanged.Checklist