fix(helm): propagate common split service settings - #2537
Open
charlesbluca wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryThe PR restores common
|
| Filename | Overview |
|---|---|
| nemo_retriever/helm/templates/deployment.yaml | Propagates common service settings into all split-topology workloads without an eligible follow-up defect. |
| nemo_retriever/tests/test_helm_split_common_service_settings.py | Adds sentinel-based assertions covering common split Deployment settings and worker init-container security contexts. |
| nemo_retriever/helm/README.md | Documents the common service settings inherited by split-topology workloads. |
| nemo_retriever/helm/openshift.md | Clarifies security-context propagation for split service and gateway-wait containers on OpenShift. |
| docs/docs/extraction/releasenotes.md | Records the split-topology Helm rendering correction. |
Reviews (2): Last reviewed commit: "style: format split Helm regression test" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix split-topology Helm rendering so common
service.*settings propagate to the gateway, realtime, and batch workloads.The split Deployment branch was missing the standalone renderers common metadata, scheduling, container security, environment, volume, and shutdown settings. It also defaulted termination grace periods to 15 seconds and left worker
wait-for-gatewayinit containers without the configured container security context.This change restores parity, adds a sentinel-based Helm render regression test, and updates Helm, OpenShift, and release-note documentation.
Validation
helm templatewith split-mode sentinel values and manifest assertions.helm lint nemo_retriever/helm --set nims.enabled=false --set serviceConfig.vectordb.enabled=false --set topology.mode=split.git -c core.whitespace=cr-at-eol diff --check.pytestand strict MkDocs build are unavailable in this environment.Checklist