Fix Helm reranker endpoint configuration - #2480
Open
nvwizhu wants to merge 2 commits into
Open
Conversation
Signed-off-by: wizhu <wizhu@nvidia.com>
nvwizhu
force-pushed
the
agent/fix-helm-reranker-config
branch
from
August 13, 2026 17:32
7e7e878 to
7be4920
Compare
nvwizhu
marked this pull request as ready for review
August 13, 2026 17:34
Contributor
Greptile SummaryThe PR exposes remote reranker endpoint and model settings through Helm, renders them into every service topology, and rejects model-only configurations before deployment.
|
| Filename | Overview |
|---|---|
| nemo_retriever/helm/templates/configmap.yaml | Renders reranker settings across all service ConfigMaps and fail-fast rejects the previously reported model-only configuration. |
| nemo_retriever/helm/values.yaml | Adds empty defaults for the two new user-configurable reranker values. |
| nemo_retriever/helm/README.md | Documents the endpoint/model relationship and explicitly states that the endpoint is not auto-resolved. |
| nemo_retriever/tests/test_helm_rerank_endpoint.py | Covers standalone and split rendering, URL-only configuration, and absent or whitespace-only endpoints paired with a model. |
Reviews (2): Last reviewed commit: "Validate Helm reranker model configurati..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Retriever service supports
nim_endpoints.rerank_invoke_urlandnim_endpoints.rerank_model_name, but the Helm chart did not expose or render corresponding values. As a result, reranker settings supplied through Helm were not included inretriever-service.yaml, and/v1/queryrequests withrerank=truecould return HTTP 400.This change:
serviceConfig.nimEndpoints.rerankInvokeUrlandserviceConfig.nimEndpoints.rerankModelNamenim_endpoints.rerank_invoke_urlandnim_endpoints.rerank_model_nameValidation
helm lint --strict nemo_retriever/helmpytest -q nemo_retriever/tests/test_helm_rerank_endpoint.py— 5 passedgit diff --checkChecklist