Skip to content

fix: add actions: write permission for v4 artifact upload - #2473

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/nrl-docs-nvidia-publish-add-actions-write-permission-for-v4
Open

fix: add actions: write permission for v4 artifact upload#2473
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/nrl-docs-nvidia-publish-add-actions-write-permission-for-v4

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in .github/workflows/nrl-docs-nvidia-publish.yml: add actions: write permission for v4 artifact upload.

Changes

  • .github/workflows/nrl-docs-nvidia-publish.yml: add actions: write permission for v4 artifact upload.

Details

--- a/.github/workflows/nrl-docs-nvidia-publish.yml
+++ b/.github/workflows/nrl-docs-nvidia-publish.yml
@@ -1,2 +1,3 @@
-permissions:
-  contents: read
+permissions:
+  contents: read
+  actions: write

Tests

  • tests/test_nrl_docs_permissions.py
diff --git a/tests/test_nrl_docs_permissions.py b/tests/test_nrl_docs_permissions.py
new file mode 100644
--- /dev/null
+++ b/tests/test_nrl_docs_permissions.py
@@ -0,0 +1,17 @@
+"""Validate required permissions for the NRL docs publish workflow."""
+import os
+import re
+import unittest
+
+
+class TestNrlDocsPermissions(unittest.TestCase):
+    def test_publish_workflow_has_actions_write(self):
+        repo_root = os.path.dirname(os.path.dirname(__file__))
+        path = os.path.join(repo_root, ".github", "workflows", "nrl-docs-nvidia-publish.yml")
+        with open(path, encoding="utf-8") as f:
+            workflow = f.read()
+        perm_block = re.search(r"^permissions:\n((?:[ ]{2,}\S.*\n)*)", workflow, re.MULTILINE)
+        self.assertIsNotNone(perm_block)
+        self.assertIn("actions: write", perm_block.group(0))
+        self.assertIn("contents: read", perm_block.group(0))
+
+
+if __name__ == "__main__":
+    unittest.main()

Contributor guidelines

Per this repo's CONTRIBUTING.md:

  • All commits are signed off (Signed-off-by trailer, DCO).

Signed-off-by: awhite <awhite@acl-dgxh200-1.cm.cluster>
@andrewwhitecdw
andrewwhitecdw requested review from a team as code owners August 13, 2026 00:11
@andrewwhitecdw
andrewwhitecdw requested a review from jdye64 August 13, 2026 00:11
@copy-pr-bot

copy-pr-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (258 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant