fix: reserve Ray task capacity in batch admission - #2454
Open
jioffe502 wants to merge 3 commits into
Open
Conversation
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 13, 2026 08:19
fcc2c46 to
4509cfd
Compare
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 13, 2026 18:50
4509cfd to
80f6f93
Compare
jioffe502
marked this pull request as ready for review
August 13, 2026 19:12
Contributor
Greptile SummaryThis PR updates batch-mode Ray admission to reserve capacity for schema-normalization tasks and automatically scales file-backed text extraction.
|
| Filename | Overview |
|---|---|
| nemo_retriever/src/nemo_retriever/graph/executor.py | Extends shared and per-executor preflight with non-actor CPU reservations, tuple-aware capacity accounting, and resource-allocation logging. |
| nemo_retriever/src/nemo_retriever/graph/ingestor_runtime.py | Adds a bounded automatic CPU-only actor pool for batch text extraction and marks it eligible for preflight reduction. |
| nemo_retriever/src/nemo_retriever/ingestor/branch_extraction.py | Passes effective extraction mode into tuning and reserves normalization-task capacity during multi-dataset branch execution. |
| nemo_retriever/src/nemo_retriever/ingestor/graph_ingestor.py | Propagates the effective extraction mode into batch override derivation. |
| docs/docs/extraction/performance_guide.md | Documents normalization reservations, bounded text-worker sizing, explicit-plan authority, and actor-pool tuple semantics. |
| nemo_retriever/tests/test_ingest_manifest.py | Updates branch preflight tests to verify normalization CPU reservations. |
| nemo_retriever/tests/test_ingest_plans.py | Tests automatic text-pool creation and reduction for filesystem-reader capacity. |
| nemo_retriever/tests/test_pipeline_graph.py | Tests non-actor CPU reservation and infeasible two-element actor-pool tuples. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Resolve batch execution graphs] --> B[Count source-read CPUs]
A --> C[Count normalization task CPUs]
A --> D[Resolve actor CPU and GPU requests]
B --> E[Compute actor CPU budget]
C --> E
D --> F{Explicit minimum plan feasible?}
E --> F
F -- No --> G[Raise infeasible-plan error]
F -- Yes --> H[Grow automatic actor pools within budget]
H --> I[Apply final concurrency overrides]
I --> J[Build and execute Ray datasets]
Reviews (5): Last reviewed commit: "Merge branch 'main' into jioffe502/graph..." | Re-trigger Greptile
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 13, 2026 19:16
80f6f93 to
55720e2
Compare
Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 14, 2026 16:16
97d7ed0 to
d1e7928
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current batch admission reserves CPU for filesystem source reads, but two scheduling gaps remain:
This PR reserves the remaining known task capacity after the complete execution graph is resolved and gives file-backed text a bounded automatic worker pool.
What changes
(min, max)and(min, max, initial)Ray actor-pool tuples as requested capacity.BatchTuningParamsandnode_overridesauthoritative; infeasible explicit plans fail before execution.Filesystem-reader capacity remains owned by the existing
source_cpu_reservationcontract. This PR adds normalization capacity without counting source readers twice.Evidence
The text-worker change improves extraction throughput, not total BrowseComp wall time: embedding and the final store remain the dominant stages after extraction is parallelized.
Scope
run_mode="batch"only.Validation
Reviewer focus