Skip to content

test(helm): expect Recommended minimal install (26.08) in README check - #2453

Merged
jperez999 merged 1 commit into
NVIDIA:mainfrom
kheiss-uwzoo:fix/helm-readme-minimal-install-2608
Aug 11, 2026
Merged

test(helm): expect Recommended minimal install (26.08) in README check#2453
jperez999 merged 1 commit into
NVIDIA:mainfrom
kheiss-uwzoo:fix/helm-readme-minimal-install-2608

Conversation

@kheiss-uwzoo

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • pytest nemo_retriever/tests/test_helm_optional_nims_disabled_by_default.py::OptionalNimsDefaultDisabledTests::test_readme_minimal_install_no_longer_disables_parse_or_omni
  • CI unit tests green on this PR

Follow-up after NVIDIA#2430: the Helm README section was rebranded to 26.08, but the unit test marker still expected 26.05.
@kheiss-uwzoo
kheiss-uwzoo requested review from a team as code owners August 11, 2026 21:57
@kheiss-uwzoo
kheiss-uwzoo requested a review from edknv August 11, 2026 21:57
@kheiss-uwzoo

Copy link
Copy Markdown
Collaborator Author

Follow-up for Julio: #2430 merged before this README unit-test marker update landed. This PR is the one-line test fix for Recommended minimal install (26.08).

@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR synchronizes a Helm README regression test with the minimal-install section renamed for release 26.08.

  • Updates the expected README heading marker from 26.05 to 26.08.
  • Updates the corresponding test documentation and failure message.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The updated marker uniquely matches the current Helm README heading, and the existing test continues to inspect the intended minimal-install recipe.

Important Files Changed

Filename Overview
nemo_retriever/tests/test_helm_optional_nims_disabled_by_default.py Correctly updates the stale README section marker and related explanatory text to match the unique 26.08 heading.

Reviews (1): Last reviewed commit: "test(helm): expect Recommended minimal i..." | Re-trigger Greptile

@kheiss-uwzoo kheiss-uwzoo self-assigned this Aug 11, 2026
@kheiss-uwzoo
kheiss-uwzoo requested a review from jperez999 August 11, 2026 22:00
@jperez999
jperez999 merged commit 529361c into NVIDIA:main Aug 11, 2026
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants