-
Notifications
You must be signed in to change notification settings - Fork 55
feat(adaptive): add opt-in caching for tool results #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhongxuanwang-nv
wants to merge
30
commits into
NVIDIA:main
Choose a base branch
from
zhongxuanwang-nv:feat/response-cache-stage3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
3f67405
feat(response-cache): add tool-result caching
zhongxuanwang-nv 8d7dec7
test(response-cache): cover cache failure paths
zhongxuanwang-nv f42971d
fix(response-cache): harden tool result caching
zhongxuanwang-nv 2c5789d
fix(response-cache): harden tool cache safety
zhongxuanwang-nv cd92e5d
chore: keep tool cache docs in documentation PR
zhongxuanwang-nv 3f9e2a9
fix: use v1 response cache version identifiers
zhongxuanwang-nv deb61a5
fix(response-cache): address review feedback
zhongxuanwang-nv 7c13df4
test(cli): use live doctor probe helper
zhongxuanwang-nv fa88208
fix(response-cache): reject broad tool caching
zhongxuanwang-nv 635ee09
test(response-cache): tighten tool cache coverage
zhongxuanwang-nv 0f2281d
fix(cli): report tool cache configuration offline
zhongxuanwang-nv 8c200ea
test(response-cache): isolate cache surface keys
zhongxuanwang-nv 428b8b0
test(response-cache): inspect mark metadata object
zhongxuanwang-nv 9fe18ed
test(cli): configure tool cache diagnostics
zhongxuanwang-nv 1ccf18c
ci: use setup Python for Rust and Node jobs
zhongxuanwang-nv c658c2d
ci: use setup Python for Python jobs
zhongxuanwang-nv d02ce64
Merge remote-tracking branch 'origin/main' into feat/response-cache-s…
zhongxuanwang-nv ce9cad1
revert: restore CI workflows from main
zhongxuanwang-nv 30e010f
Merge remote-tracking branch 'origin/main' into feat/response-cache-s…
zhongxuanwang-nv 5980c83
refactor(response-cache): type cache decision labels
zhongxuanwang-nv eea1bb7
fix(ci): avoid manual uv Python downloads
zhongxuanwang-nv 0a4b538
Merge origin/main into feat/response-cache-stage3
zhongxuanwang-nv fc3dc7b
fix(response-cache): preserve tool result annotations
zhongxuanwang-nv 051db37
chore: retrigger Codecov after main merge
zhongxuanwang-nv 2c9349e
test(response-cache): move tool policy tests out of src
zhongxuanwang-nv 8554398
test(response-cache): restore benchmark separator
zhongxuanwang-nv b0253a9
feat(response-cache): inherit tool versions from classes
zhongxuanwang-nv 6bcd253
test(core): remove unrelated sanitizer debug coverage
zhongxuanwang-nv ec4979d
fix(response-cache): tighten tool policy configuration
zhongxuanwang-nv d090ea7
fix(response-cache): preserve default v1 cache keys
zhongxuanwang-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this priority selected?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! I think here is just wants a default value higher than the NeMo Guardrails + PII redaction's default value (which is 100), so guardrails/redaction can run before cache lookups :) Do you think we should keep this default priority?