[DEMO] tomllib import env regression (perf-gate HARD_FAILURE) - #7
Open
Neil4561 wants to merge 3 commits into
Open
[DEMO] tomllib import env regression (perf-gate HARD_FAILURE)#7Neil4561 wants to merge 3 commits into
Neil4561 wants to merge 3 commits into
Conversation
added 2 commits
June 25, 2026 18:17
Trim the benchmark matrix to the two well-baselined demo tasks (physx + newton each) for a fast, clean four-cell verdict table. Demo only; not for merge.
Simulate the environment-regression class where a PR adds 'import tomllib' (stdlib only on Python 3.11+) while the benchmark image still ran Python 3.10, crashing every task at import before any perf data is produced. The perf gate then reports HARD_FAILURE for all cells (no FPS to compare). The perf-gate image is Python 3.11, so the failure is reproduced deterministically with an explicit ModuleNotFoundError guard. Demo only; not for merge.
Include the newly-seeded Factory-GearMesh task so the HARD_FAILURE table covers a third task as well. Demo only; not for merge.
Performance Smoke ResultsBaseline read SHA: Run context
How to read this table
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo PR (not for merge)
HARD_FAILURE case for the performance smoke-test demo.
Change: simulates the environment-regression class where benchmark startup breaks before any FPS data is produced.
Reference case: this is modeled after commit
a337c0b, which addedimport tomllibto the install CLI.tomllibis only available in the Python standard library starting in Python 3.11, so a Python 3.10 CI image would fail during import before any benchmark could run.Explanation: this mirrors the real environment-regression failure mode we discussed. The benchmark crashes during import/startup, before it can initialize the environment or enter the simulation loop. Since there is no usable FPS series, the gate should report
HARD_FAILUREfor each affected cell instead of treating it like a normal slowdown.The current perf image uses Python 3.11, so this demo reproduces the same class of failure deterministically with an explicit import failure guard. The point of the demo is the verdict behavior: startup/import failures are separated from performance regressions.
Matrix:
Isaac-Cartpole-Direct+Isaac-Factory-GearMesh-Direct-v0(physx) +Isaac-Velocity-Flat-G1-v0.Trigger via mirror to
pull-request/<N>orworkflow_dispatch.