Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ rust-version = "1.96.1"
[workspace.dependencies]
async-stream = "0.3"
async-trait = "0.1"
base64 = "0.22"
futures = "0.3"
futures-util = "0.3"
http = "1"
Expand Down
1 change: 1 addition & 0 deletions crates/switchyard-translation/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ keywords = ["llm", "translation", "openai", "anthropic"]
publish = ["crates-io"]

[dependencies]
base64.workspace = true
serde.workspace = true
serde_json.workspace = true
switchyard-protocol.workspace = true
Expand Down
12 changes: 6 additions & 6 deletions crates/switchyard-translation/src/codecs/anthropic/buffered.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ use crate::llm::{
SamplingParams, StopReason, ToolCall, ToolChoice, ToolDefinition, ToolResult, Usage,
};
use crate::policy::{DeterministicIdPolicy, TranslationPolicy};
use crate::util::sanitize_anthropic_tool_use_id;
use crate::util::{
capture_request_preservation, capture_response_preservation, embed_preservation,
exact_preserved_request, exact_preserved_response,
capture_request_preservation, capture_response_preservation, desanitize_anthropic_tool_use_id,
embed_preservation, exact_preserved_request, exact_preserved_response,
sanitize_anthropic_tool_use_id,
};
use crate::util::{
json_string, push_lossy, stable_id, string_value, validate_request_capabilities,
Expand Down Expand Up @@ -589,7 +589,7 @@ fn decode_anthropic_content_block(
.get("id")
.and_then(Value::as_str)
.filter(|id| !id.is_empty())
.map(ToOwned::to_owned)
.map(desanitize_anthropic_tool_use_id)
.unwrap_or_else(|| match &policy.deterministic_ids {
DeterministicIdPolicy::GenerateStable { prefix } => {
stable_id(prefix, generated_counter)
Expand All @@ -607,8 +607,8 @@ fn decode_anthropic_content_block(
tool_call_id: block
.get("tool_use_id")
.and_then(Value::as_str)
.unwrap_or_default()
.to_string(),
.map(desanitize_anthropic_tool_use_id)
.unwrap_or_default(),
content: decode_tool_result_content(block.get("content").unwrap_or(&Value::Null)),
is_error: block.get("is_error").and_then(Value::as_bool),
})],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use crate::codecs::stream::{
target_message_id_or_source_message_id, target_model_or_source_model,
};
use crate::format::{FormatId, WireFormat};
use crate::util::sanitize_anthropic_tool_use_id;
use crate::util::{desanitize_anthropic_tool_use_id, sanitize_anthropic_tool_use_id};

/// Stream codec for Anthropic Messages events.
pub struct AnthropicMessagesStreamCodec;
Expand Down Expand Up @@ -336,7 +336,7 @@ fn decode_anthropic_content_block_start(object: &Map<String, Value>) -> Vec<LlmR
id: block
.get("id")
.and_then(Value::as_str)
.map(ToOwned::to_owned),
.map(desanitize_anthropic_tool_use_id),
name: block
.get("name")
.and_then(Value::as_str)
Expand Down
77 changes: 62 additions & 15 deletions crates/switchyard-translation/src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

use std::collections::BTreeMap;

use base64::{Engine as _, engine::general_purpose::URL_SAFE_NO_PAD};
use serde_json::{Map, Value, json};

use crate::diagnostic::TranslationDiagnostic;
Expand All @@ -20,6 +21,8 @@ pub const SWITCHYARD_METADATA_KEY: &str = "_switchyard_translation";
/// Public alias for the embedded preservation metadata key.
pub const PRESERVATION_METADATA_KEY: &str = SWITCHYARD_METADATA_KEY;

const ANTHROPIC_TOOL_ID_ENCODING_PREFIX: &str = "sy64_";

/// Reads a JSON object or returns a typed translation error at the given path.
pub fn object<'a>(value: &'a Value, path: &str) -> Result<&'a Map<String, Value>> {
value
Expand Down Expand Up @@ -327,23 +330,33 @@ pub fn normalize_anthropic_tool_use_ids(value: Value) -> Value {
}
}

/// Converts a single ID into Anthropic-safe characters.
/// Converts an ID into a reversible Anthropic-safe representation.
pub fn sanitize_anthropic_tool_use_id(raw: &str) -> String {
let sanitized = raw
.chars()
.map(|ch| {
if ch.is_ascii_alphanumeric() || ch == '_' || ch == '-' {
ch
} else {
'_'
}
})
.collect::<String>();
if sanitized.is_empty() {
"toolu_empty".to_string()
} else {
sanitized
let is_safe = !raw.is_empty()
&& raw
.bytes()
.all(|byte| byte.is_ascii_alphanumeric() || byte == b'_' || byte == b'-');
if is_safe && !raw.starts_with(ANTHROPIC_TOOL_ID_ENCODING_PREFIX) {
return raw.to_string();
}

format!(
"{ANTHROPIC_TOOL_ID_ENCODING_PREFIX}{}",
URL_SAFE_NO_PAD.encode(raw.as_bytes())
)
}

/// Restores an ID encoded by [`sanitize_anthropic_tool_use_id`].
pub(crate) fn desanitize_anthropic_tool_use_id(encoded: &str) -> String {
let Some(payload) = encoded.strip_prefix(ANTHROPIC_TOOL_ID_ENCODING_PREFIX) else {
return encoded.to_string();
};

URL_SAFE_NO_PAD
.decode(payload)
.ok()
.and_then(|bytes| String::from_utf8(bytes).ok())
.unwrap_or_else(|| encoded.to_string())
}

// Normalizes every content block in one Anthropic message.
Expand Down Expand Up @@ -441,3 +454,37 @@ fn stable_suffix(raw: &str) -> String {
}
format!("{hash:08x}")
}

#[cfg(test)]
mod tests {
use super::{desanitize_anthropic_tool_use_id, sanitize_anthropic_tool_use_id};

// Keeps ordinary provider IDs unchanged while making unsafe IDs reversible.
#[test]
fn anthropic_tool_id_encoding_round_trips() {
assert_eq!(
sanitize_anthropic_tool_use_id("call_abc-123"),
"call_abc-123"
);

for raw in ["", "functions.list_skills:0", "工具/lookup"] {
let encoded = sanitize_anthropic_tool_use_id(raw);
assert!(
encoded
.bytes()
.all(|byte| byte.is_ascii_alphanumeric() || byte == b'_' || byte == b'-')
);
assert_eq!(desanitize_anthropic_tool_use_id(&encoded), raw);
}
}

// Escapes the reserved prefix and leaves malformed encoded values untouched.
#[test]
fn anthropic_tool_id_encoding_disambiguates_its_prefix() {
let raw = "sy64_Zm9v";
let encoded = sanitize_anthropic_tool_use_id(raw);
assert_ne!(encoded, raw);
assert_eq!(desanitize_anthropic_tool_use_id(&encoded), raw);
assert_eq!(desanitize_anthropic_tool_use_id("sy64_%%%"), "sy64_%%%");
}
}
22 changes: 17 additions & 5 deletions crates/switchyard-translation/tests/request_translation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use pretty_assertions::assert_eq;
use serde_json::{Value, json};
use switchyard_translation::{
LossyConversionPolicy, TranslationEngine, TranslationPolicy, WireFormat,
sanitize_anthropic_tool_use_id,
};

use common::{REASONING_MODEL, normalized_policy, shell_tool_call};
Expand Down Expand Up @@ -285,12 +286,17 @@ fn anthropic_unknown_content_does_not_leak_into_responses_request_blocks() -> Te
#[test]
fn anthropic_tool_result_followup_text_splits_to_openai_messages() -> TestResult {
let engine = TranslationEngine::default();
let raw_id = "functions.list_skills:0";
let body = json!({
"model": "claude-sonnet-4-20250514",
"messages": [{
"role": "user",
"content": [
{"type": "tool_result", "tool_use_id": "toolu_1", "content": "72F"},
{
"type": "tool_result",
"tool_use_id": sanitize_anthropic_tool_use_id(raw_id),
"content": "72F"
},
{"type": "text", "text": "Now summarize it."}
]
}],
Expand All @@ -309,7 +315,7 @@ fn anthropic_tool_result_followup_text_splits_to_openai_messages() -> TestResult
assert_eq!(
output["messages"],
json!([
{"role": "tool", "tool_call_id": "toolu_1", "content": "72F"},
{"role": "tool", "tool_call_id": raw_id, "content": "72F"},
{"role": "user", "content": "Now summarize it."}
])
);
Expand Down Expand Up @@ -1723,12 +1729,16 @@ fn openai_tool_results_are_merged_when_translating_to_anthropic() -> TestResult

assert_eq!(
output["messages"][1]["content"][0]["id"],
"call_bad_id_with_space"
sanitize_anthropic_tool_use_id("call.bad:id/with space")
);
assert_eq!(
output["messages"][2]["content"],
json!([
{"type": "tool_result", "tool_use_id": "call_bad_id_with_space", "content": "one"},
{
"type": "tool_result",
"tool_use_id": sanitize_anthropic_tool_use_id("call.bad:id/with space"),
"content": "one"
},
{"type": "tool_result", "tool_use_id": "call_2", "content": "two"}
])
);
Expand Down Expand Up @@ -1984,6 +1994,7 @@ fn responses_to_chat_preserves_tool_choice_when_tools_survive() -> TestResult {
#[test]
fn anthropic_tool_use_encodes_responses_arguments_as_json_string() -> TestResult {
let engine = TranslationEngine::default();
let raw_id = "functions.list_skills:0";
let body = json!({
"model": "claude-sonnet",
"messages": [
Expand All @@ -1992,7 +2003,7 @@ fn anthropic_tool_use_encodes_responses_arguments_as_json_string() -> TestResult
"role": "assistant",
"content": [{
"type": "tool_use",
"id": "toolu_1",
"id": sanitize_anthropic_tool_use_id(raw_id),
"name": "get_weather",
"input": {"city": "SF"}
}]
Expand All @@ -2018,6 +2029,7 @@ fn anthropic_tool_use_encodes_responses_arguments_as_json_string() -> TestResult
let arguments = call["arguments"]
.as_str()
.ok_or("function_call arguments must be a JSON string")?;
assert_eq!(call["call_id"], raw_id);
assert_eq!(
serde_json::from_str::<Value>(arguments)?,
json!({"city": "SF"})
Expand Down
32 changes: 32 additions & 0 deletions crates/switchyard-translation/tests/stream_translation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,38 @@ fn openai_chat_stream_event_translates_to_anthropic_message_events() -> TestResu
Ok(())
}

// Restores Anthropic-safe IDs before emitting OpenAI tool-call deltas.
#[test]
fn anthropic_stream_tool_id_is_restored_for_openai_chat() -> TestResult {
let engine = TranslationEngine::default();
let mut state =
StreamTranslationState::new(WireFormat::AnthropicMessages, WireFormat::OpenAiChat);
let raw_id = "functions.list_skills:0";
let event = json!({
"type": "content_block_start",
"index": 0,
"content_block": {
"type": "tool_use",
"id": "sy64_ZnVuY3Rpb25zLmxpc3Rfc2tpbGxzOjA",
"name": "list_skills",
"input": {}
}
});

let chunks = engine.translate_event(
&mut state,
WireFormat::AnthropicMessages,
WireFormat::OpenAiChat,
&event,
)?;

assert_eq!(
chunks[0]["choices"][0]["delta"]["tool_calls"][0]["id"],
raw_id
);
Ok(())
}

// A mixed chunk must emit reasoning before text, matching the buffered decoder.
#[test]
fn openai_chat_mixed_reasoning_and_content_stream_in_reasoning_first_order() -> TestResult {
Expand Down