Introduce global disable_thresholds setting - #134
Draft
martialblog wants to merge 2 commits into
Draft
Conversation
Member
Author
|
@domme0711 Hi, would that be a solution for the use case you proposed? I'm not 100% sure about it yet, but something in that direction probably. |
Contributor
|
@martialblog Hi! I did not test it yet, but it looks good. I've created a patch and did the same change in library/Perfdatagraphs/Model/PerfdataSet.php and set the declaration of showThresholds in this class to false. That works as a interim solution for me and should not affect the show_threshold option that you can set per metric. I'll look into it further. |
Contributor
|
@martialblog |
martialblog
commented
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.