Fixing NSF project award function and maintenance of package#207
Open
justinkadi wants to merge 7 commits into
Open
Fixing NSF project award function and maintenance of package#207justinkadi wants to merge 7 commits into
justinkadi wants to merge 7 commits into
Conversation
Removed an extra comma from the person entry for Jasmine Lai.
There was a problem hiding this comment.
Pull request overview
This PR focuses on package maintenance and on fixing NSF award → EML project extraction behavior, along with associated test and metadata updates.
Changes:
- Updates
eml_nsf_to_project()support code and adjusts EML-related tests. - Refreshes package metadata/docs (DESCRIPTION, NAMESPACE, package Rd) and CI caching action version.
- Removes deprecated
context()calls from testthat tests.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test_util.R | Removes deprecated context() header. |
| tests/testthat/test_sysmeta.R | Removes deprecated context() header. |
| tests/testthat/test_packaging.R | Removes deprecated context() header. |
| tests/testthat/test_helpers.R | Removes deprecated context() header. |
| tests/testthat/test_formats.R | Removes deprecated context() header. |
| tests/testthat/test_environment.R | Removes deprecated context() header. |
| tests/testthat/test_eml.R | Updates warning/error expectations for NSF award handling. |
| tests/testthat/test_editing.R | Removes deprecated context() header. |
| tests/testthat/test_dataone.R | Removes deprecated context() header. |
| tests/testthat/test_access.R | Removes deprecated context() header. |
| R/eml.R | Modifies NSF personnel name parsing helper and adds raster import tag for raster metadata helper. |
| NAMESPACE | Adds import(raster). |
| man/arcticdatautils.Rd | Expands package-level aliases and author/links sections. |
| DESCRIPTION | Adds contributor, updates RoxygenNote, adjusts dependency listing. |
| .github/workflows/R-CMD-check.yaml | Updates cache action from actions/cache@v1 to @v4. |
Files not reviewed (1)
- man/arcticdatautils.Rd: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
446
to
+451
| firstName = unlist(lapply(x, function(x){head(strsplit(x, split = " ")[[1]], 1)})), | ||
| lastName = unlist(lapply(x, function(x) {paste(tail(strsplit(x, split = " ")[[1]], -1), collapse = " ")})) | ||
| lastName = unlist(lapply(x, function(x) { | ||
| paste( | ||
| head( | ||
| tail( | ||
| strsplit(x, split = " ")[[1]], |
Comment on lines
54
to
56
| purrr, | ||
| raster, | ||
| rmarkdown, | ||
| sf, |
Comment on lines
+275
to
+278
| # test to be sure that missing award numbers generates warning | ||
| expect_warning(proj <- eml_nsf_to_project(awards), class="warning") | ||
| # test to be sure that a list with no valid award number generates error | ||
| expect_error(expect_warning(proj <- eml_nsf_to_project(c("abcdef")))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging changes from Matt's initial example maintenance of the package. Namely, fixing the function to extract NSF award info. Then I fixed some tests.