DSE Hub: delete meetings (hold-to-delete) + light dropdowns + UX polish - #223
Open
kyle-lesinger wants to merge 1 commit into
Open
DSE Hub: delete meetings (hold-to-delete) + light dropdowns + UX polish#223kyle-lesinger wants to merge 1 commit into
kyle-lesinger wants to merge 1 commit into
Conversation
- Meetings can be removed: a `delete` op in the ChangeDoc model (changesData.ts), honored by the runtime loader (meetings/data.ts) and scripts/compact.mjs (upsert/delete by id, newest ts wins). Staged in the Changes cart -> PR-gated. - Delete is a press-and-HOLD (2s) gesture (HoldToDelete.tsx), not a click; the "Delete meeting" button lives in the shared MeetingDetail so it shows in the list, calendar popovers, and categories. - Native <datalist> rendered dark/misaligned on a dark-mode OS -> Team/Category now use a custom light Combobox.tsx; color-scheme:light (index.html + styles) pins native <select>/date popups to light. - UX: bigger, softer form/modal (larger radii, softer shadows, roomier inputs, pill legends), plus a .btn.danger variant. - Docs: DSE_HUB.md + CLAUDE.md note the delete op and light-native-control rule.
✅ Deploy Preview for veda-github-actions canceled.
|
✅ Deploy Preview for veda-dse-hub ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for veda-aws-dashboard canceled.
|
✅ Deploy Preview for veda-leave-dashboard canceled.
|
✅ Deploy Preview for veda-pr-dashboard canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
deleteop in the ChangeDoc model (changesData.ts), honored by the runtime loader (meetings/data.ts) andscripts/compact.mjs— upsert/delete by id, newesttswins. Deletions stage in the Changes cart and are PR-gated (never an instant removal).HoldToDelete.tsx— press-and-hold with a fill bar; releasing early aborts. The "Delete meeting" button lives in the sharedMeetingDetail, so it appears in the List, Calendar popovers, and Categories.<datalist>rendered dark/misaligned on a dark-mode OS, so Team/Category now use a custom lightCombobox.tsx;color-scheme: light(index.html +:root) pins native<select>/date popups to light..btn.dangervariant.docs/DSE_HUB.md+CLAUDE.mddocument the delete op and the light-native-control rule.Verify
npm run typecheckclean,npm run buildgreen; Playwright: quick click stages nothing, a full 2s hold stages onedeletedoc; Team/Category dropdowns render light and aligned.