Timeline plugin: playback controls - #242
Open
sandesh-sp wants to merge 4 commits into
Open
Conversation
Replaces the playback placeholders with the real controls: skip to start and end, step back and forward, play/pause, and a button that cycles the speed multiplier through 1x, 2x, 4x and 0.5x. The play button and the speed button are hidden when a mission turns playback off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AgqjkZhQvfoBgdJtt9SSKS
This was referenced Jul 31, 2026
- Name every icon-only button, expose play/pause through aria-pressed, and group the transport under a labelled role. - Disable the step and skip buttons at the end of the range they move toward, so a button that cannot act now looks and reads as inert. The adapter clamps rather than dropping the step, so the buttons stay live until the boundary is actually reached. - Restart the speed cycle from a value outside it, keeping the playback interval from being handed a zero or negative multiplier.
Collaborator
Author
|
Review pass over the stack (#239–#243). Pushed as Worth flagging up front: the playback engine these controls drive lives in In this PR
Fixed in #239 (engine side)
On throttling: I looked at whether 4x playback hammers core too hard and concluded it doesn't — core's own TimeUI ships a 100ms interval on the identical path (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the playback placeholders with the real controls: skip to start/end, step back/forward, play/pause, and a button cycling the speed multiplier through 1x, 2x, 4x, 0.5x. Play and speed are hidden when a mission turns playback off.
Stack — merge in order, starting from the base:
development