Skip to content

Safely run user code in isolated VMs, add isolation tests & result serializer option - #39

Merged
dandelany merged 17 commits into
developfrom
feature/isolated-vm
Aug 3, 2026
Merged

Safely run user code in isolated VMs, add isolation tests & result serializer option#39
dandelany merged 17 commits into
developfrom
feature/isolated-vm

Conversation

@dandelany

@dandelany dandelany commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Updates the library to use v8 VM isolates (via the isolated-vm library).

Breaking Changes:

  • Node 24 is now required, in order to support latest & most secure v8 features
  • VM context argument removed and replaced with new options argument
  • User may now pass an additional option to specify a "result serializer" module which will be run on the result of the user's code before returning

Remaining To Do:

  • update docs
    • new options object, no context option
    • memory limit option
    • globals option
    • result seralizer
  • more function doc strings
  • broken unit tests
  • out-of-date dependency - stack-trace

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@duranb duranb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread .github/workflows/test.yml Fixed
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@dandelany

Copy link
Copy Markdown
Collaborator Author

Tests and GH scripts are updated and code has been reviewed with @duranb . I'm going to merge it so i can publish it to NPM as v1.0.0-rc0 (with the next tag instead of latest) and integrate with the backend. Will handle remaining minor things in a follow-up.

@dandelany
dandelany merged commit 71c3f2b into develop Aug 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants