fix: clippy lints across lib and test targets#85
Closed
N4M3Z wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI fails on every PR: the runners' Rust 1.97 clippy added
question_mark(fires insrc/yaml/mod.rs) and stricter format lints in test targets, all denied under-D warnings. forge-cli#84 is red through no fault of its diff.Fix
Apply the machine-suggested rewrites:
?instead of thematchin the yaml path walker, string literals instead of argument-lessformat!, inlined format args, and a method reference instead of a redundant closure. No behavior change.Test plan
cargo clippy --all-targets -- -D warningscleancargo testgreen (478 tests)cargo fmtapplied, prek gate green, tree secret scan clean