Skip to content

fix: clippy lints across lib and test targets#85

Closed
N4M3Z wants to merge 1 commit into
mainfrom
clippy-lints
Closed

fix: clippy lints across lib and test targets#85
N4M3Z wants to merge 1 commit into
mainfrom
clippy-lints

Conversation

@N4M3Z

@N4M3Z N4M3Z commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Problem

CI fails on every PR: the runners' Rust 1.97 clippy added question_mark (fires in src/yaml/mod.rs) and stricter format lints in test targets, all denied under -D warnings. forge-cli#84 is red through no fault of its diff.

Fix

Apply the machine-suggested rewrites: ? instead of the match in the yaml path walker, string literals instead of argument-less format!, inlined format args, and a method reference instead of a redundant closure. No behavior change.

Test plan

  • cargo clippy --all-targets -- -D warnings clean
  • cargo test green (478 tests)
  • cargo fmt applied, prek gate green, tree secret scan clean

@N4M3Z

N4M3Z commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

Superseded: every lint fixed here has landed on main via #86's precursors and #87. Rebasing onto main leaves an empty diff.

@N4M3Z N4M3Z closed this Jul 13, 2026
@N4M3Z
N4M3Z deleted the clippy-lints branch July 13, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant