Add assertation for bad links and only log latest version of modules#146
Conversation
| result.push(str); | ||
|
|
||
| if (linkMatches.length > 0) { | ||
| log.error( |
There was a problem hiding this comment.
Just to confirm the behavior here, this will do the whole run still right? Ideally if there are multiple issues the error output shows all of them at once so the dev can fix them all.
There was a problem hiding this comment.
Yes, it continues and the whole run is still done.
It should log every error and still generate .md and .d.ts files.
Throw new Error() would cause the run to stop and only log once
SBLMikeDemone
left a comment
SBLMikeDemone
left a comment
There was a problem hiding this comment.
The removed comments from the snapshots seem concerning and I think may lead to us posting incorrect documentation
SBLMikeDemone
left a comment
SBLMikeDemone
left a comment
There was a problem hiding this comment.
Looks good! I'd recommend updating the PR message to also document that this removes documentation on everything but the latest major version.
BrandonChanSkybox
changed the title
4 participants
Logs an error when a @ link is broken when linking symbols and is passed.
Also only logs for the latest versions of a module