Fix null error in bound function#141
Merged
Merged
Conversation
rlandav
approved these changes
Jun 24, 2026
rlandav
left a comment
rlandav
left a comment
Collaborator
There was a problem hiding this comment.
Any tests for the changelog generator that validate this?
Contributor
Author
I'm looking into this right now but, surprisingly, no. I think you need to have both the changelog generator run and a normal generation. I'm trying to recreate the situation that caused this within a test |
zachcampbellskyboxlabs
approved these changes
Jun 24, 2026
JakeShirley
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Running the generator with certain configurations caused null reference exceptions within the
boundChangesCommon Filter.Cause
This PR caused the value
undefinedto be turned into null when being serialized in a changelog: 8de3a55Fix
Serialize fields that are 'undefined' as undefined instead of null.