Skip to content

fix(player): restore embedded mpv playback - #65

Merged
ModerRAS merged 1 commit into
masterfrom
codex/fix-embedded-mpv-playback
Aug 11, 2026
Merged

fix(player): restore embedded mpv playback#65
ModerRAS merged 1 commit into
masterfrom
codex/fix-embedded-mpv-playback

Conversation

@ModerRAS

Copy link
Copy Markdown
Owner

Summary

  • use mediacodec_embed on GLES 2 devices and keep the cached VO synchronized across Surface lifecycle changes
  • fix mpv firequalizer gain_entry syntax so audio DSP initializes correctly
  • remove the unusable experimental GL runtime, dedicated surface, second Exo instance, and TV/Web entry points
  • retain the legacy EXPERIMENTAL_GL serialization token and migrate existing preferences to standard Exo
  • preserve the standard Exo libass subtitle integration from current master

Verification

  • ./gradlew test :app:assembleDebug
  • git diff --check
  • SDR MKV playback verified on a GLES 2 Android TV device through HDMI capture with advancing frames
  • HDR HEVC playback verified through HDMI capture with MediaCodec hardware decode, VO: [mediacodec_embed], and audio/video playing
  • confirmed no GL runtime/UI/Web references remain outside legacy preference migration

Versioning

Patch-level player fix. The branch is rebased onto the current 2.6.x master baseline; no major/minor version bump is needed.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ModerRAS, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a3103770-adc6-4aac-8b1a-abcc152d3fea

📥 Commits

Reviewing files that changed from the base of the PR and between 2d3fd42 and 9eb81c4.

📒 Files selected for processing (29)
  • app/src/test/kotlin/com/miruplay/tv/LaunchTestSourceContentModeTest.kt
  • core/model/src/main/kotlin/com/miruplay/tv/model/PlaybackUiConventions.kt
  • core/model/src/main/kotlin/com/miruplay/tv/model/ToneMappingModels.kt
  • data/src/test/kotlin/com/miruplay/tv/data/preferences/PlaybackPreferencesManagerTest.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/AudioDspMpvOptions.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/DeviceGlCapabilities.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/DiModule.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/EmbeddedMpvSessionOptions.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/ExoPlaybackController.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/ExperimentalHdrSdrVideoGraphFactory.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/ExperimentalHdrSurfaceMediaCodecVideoRenderer.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/ExperimentalRenderersFactory.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/ExperimentalVideoPipelineMode.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/PlaybackPlayerQualifiers.kt
  • player-core/src/main/kotlin/com/miruplay/tv/player/PlayerFactoryImpl.kt
  • player-core/src/test/kotlin/com/miruplay/tv/player/AudioDspMpvOptionsTest.kt
  • player-core/src/test/kotlin/com/miruplay/tv/player/EmbeddedMpvSessionOptionsTest.kt
  • player-core/src/test/kotlin/com/miruplay/tv/player/ExoPlaybackControllerLazyInitTest.kt
  • player-core/src/test/kotlin/com/miruplay/tv/player/ExperimentalHdrSdrVideoGraphFactoryTest.kt
  • player-core/src/test/kotlin/com/miruplay/tv/player/ExperimentalHdrSurfaceMediaCodecVideoRendererTest.kt
  • player-core/src/test/kotlin/com/miruplay/tv/player/ExperimentalVideoPipelineModeTest.kt
  • player-mpv-android/src/main/kotlin/is/xyz/mpv/BaseMPVView.kt
  • player-mpv-android/src/main/kotlin/is/xyz/mpv/MiruMpvSurfaceView.kt
  • ui-tv/src/main/kotlin/com/miruplay/tv/ui/player/GLVideoSurfaceView.kt
  • ui-tv/src/main/kotlin/com/miruplay/tv/ui/player/PlayerScreen.kt
  • ui-tv/src/main/kotlin/com/miruplay/tv/ui/settings/AddSourceScreen.kt
  • ui-tv/src/test/kotlin/com/miruplay/tv/ui/player/GLVideoSurfaceViewAttachmentPolicyTest.kt
  • web-control/src/main/kotlin/com/miruplay/tv/webcontrol/PlaybackDebugConfigMapping.kt
  • web-control/src/test/kotlin/com/miruplay/tv/webcontrol/PlaybackDebugConfigMappingTest.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ModerRAS
ModerRAS merged commit ad354db into master Aug 11, 2026
25 checks passed
@ModerRAS
ModerRAS deleted the codex/fix-embedded-mpv-playback branch August 11, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant