piu typings: fix onTouchEnded typo, Image.frameCount, firstThat/lastThat return#1651
Open
meganetaaan wants to merge 1 commit into
Open
piu typings: fix onTouchEnded typo, Image.frameCount, firstThat/lastThat return#1651meganetaaan wants to merge 1 commit into
meganetaaan wants to merge 1 commit into
Conversation
…hat return - Behavior.onTouchended -> onTouchEnded (matches Piu's event name; the mis-spelled callback was never invoked at runtime) - Image.frameCount: never -> number (native getter returns an integer) - Container.firstThat/lastThat: void -> Content | undefined (they return the content whose handler returned true, else undefined) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small, verified bug fixes in the Piu MC TypeScript definitions (
typings/piu/MC-types.d.ts). No runtime code is touched.Behavior.onTouchended→onTouchEnded— the callback was mis-spelled, so the typed handler never matched Piu's actualonTouchEndedevent and was silently ignored. Confirmed againstdocumentation/piu/piu.md(usesonTouchEndedthroughout).Image.frameCount: never→number—neveris incorrect; the native getter returns an integer (xsIntegerValue frameCountinmodules/piu/MC/piuMC.h).Container.firstThat/lastThat:void→Content | undefined— both return the content whose handler returnedtrue, otherwiseundefined. Confirmed inmodules/piu/All/piuContainer.c(xsResult = xsVar(1)), consistent with the docs describing traversal halting when a distributed event returnstrue.Verification
tsc --noEmit --strictpasses on the edited definition file.