Honor wrapper-bound literals in the generated UDF calls#41
Merged
estebanzimanyi merged 1 commit intoJul 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A SQL-hidden trailing parameter of a MEOS call gets a literal from the generator. The generic type default (
falsefor abool) diverges from the value the MobilityDB PG wrapper binds:valueAtTimestampbindsstrict=true, so a generated UDF built on the default returns the value at an exclusive bound where MobilityDB semantics return NULL.hidden_argreads the value the wrapper binds from the catalog (shape.boundArgs, provided by the MEOS-API derivation) and emits THAT for the hidden param, falling back to the generic type default when the catalog records no bound value._java_boundtranslates the C literal to its Java form (true/false,L-suffixed longs,(byte)forunsigned char), returning null for forms with no direct Java literal so the fallback applies. Both emission sites —emit_singleandemit_dispatch— route their hidden args through it.Depends on MEOS-API #61 for the per-base-type
boundArgsthe dispatch siblings read; the change is backward-compatible and keeps the generic default until that lands.