Track upstream master for the MEOS derivation#39
Merged
estebanzimanyi merged 1 commit intoJul 16, 2026
Merged
Conversation
Derive the catalog, libmeos, and the JMEOS jar all from MobilityDB master (and JMEOS main) through the shared provision-meos action, instead of pinning a MobilityDB commit in tools/meos-source-commit.txt against a committed JMEOS jar. Tracking master keeps the source in lockstep with the @master derivation toolchain (provision-meos / run.py), so the derived catalog can no longer thin out under a moving generator and drop functions the generated UDF surface needs. Build the JMEOS jar in CI from JMEOS main against that same master catalog and libmeos, and install it as org.jmeos:meos:1.0; drop the committed libs/*.jar binaries and the source-commit pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives the catalog, libmeos, and the JMEOS jar all from MobilityDB
master(and JMEOSmain) through the sharedprovision-meosaction.What
mobilitydb-ref: masterforprovision-meosand removestools/meos-source-commit.txtand its resolve step.mainagainst the same master catalog + libmeos, installed asorg.jmeos:meos:1.0, and removes the committedlibs/*.jarbinaries.Why
A pinned source under a
@masterderivation toolchain (provision-meos/run.py) drifts: deriving from a fixed commit with a movingrun.pyyields a different catalog, so the generated UDF surface diverges from the code. Trackingmasterkeeps the source and the toolchain in lockstep, mirroring the JMEOS binding. The master-derived jar's FFI signatures match the generated calls (e.g.union_float_span(double, Pointer)), so the jar and the generated UDFs stay compatible.Surface
GeneratedSurfaceTestcovers 12 cases against the master catalog —tint_value_at_timestamptz,jsonb_path_exists, and the arg-kind-dispatch surface all bind and run against the master-built libmeos through the master JMEOS jar.