Cover the H3 cell surface in the generated-surface test#38
Merged
estebanzimanyi merged 1 commit intoJul 16, 2026
Merged
Conversation
GeneratedSurfaceTest exercised every family except temporal H3. Add an h3_cell_prefilter_surface test that runs th3index, geoToH3IndexSet and the ever_eq_h3indexset_th3index prefilter end-to-end: a 4326 trip's cell is in a same-point region's cell set (true) but not in a far-away region's (false).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSurfaceTestcovers the catalog-generated UDF surface across families but has no temporal-H3 case. This addsh3_cell_prefilter_surface, exercising the H3 cell prefilter end-to-end on the generated surface:geoToH3IndexSet(geometry, resolution)on a 4326 pointth3index(tgeompoint, resolution)on a 4326 tripever_eq_h3indexset_th3indexmembership prefilter — the index-less BerlinMOD Q13 join key — asserting a trip's cell is in a same-point region's cell set (true) and not in a far-away region's (false)Geometries carry SRID=4326 because H3 requires lon/lat.