Register bbox-topological operators by their canonical SQL name#31
Merged
estebanzimanyi merged 1 commit intoJul 9, 2026
Merged
Conversation
The five bbox-topological operators (~= @> <@ -|- &&) are backed by shared C @sqlfn tags (same_bbox, contains_bbox, contained_bbox, overlaps_bbox, adjacent_bbox) that MobilityDB never deploys as CREATE FUNCTION -- the only public SQL name is the operator's bare portable alias (same, contains, contained, overlaps, adjacent). A binding that registers the raw _bbox tag leaks a function MobilityDB does not expose. The MEOS-API catalog classifies these records with sqlfnBackingOnly: true and a publicSqlName (the bare alias). Honor that flag in the UDF generator so the _bbox backing tag is never registered as a function; the bare alias and the operator are registered by the topology pass as before. Annotate the vendored catalog with the classification (surface unchanged; JMEOS jar surface preserved).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five bbox-topological operators (
~=@><@-|-&&) are backed by shared C@sqlfntags (same_bbox,contains_bbox,contained_bbox,overlaps_bbox,adjacent_bbox) that MobilityDB never deploys asCREATE FUNCTION— the only public SQL name is the operator's bare portable alias (same,contains,contained,overlaps,adjacent). Registering the raw_bboxtag as a UDF leaks a function MobilityDB does not expose.The MEOS-API catalog now classifies these records with
sqlfnBackingOnly: trueand apublicSqlName(the bare alias). This change honors that flag in the UDF generator so the_bboxbacking tag is never registered as a function; the bare alias and the operator are registered by the topology pass as before. The vendored catalog is annotated with the classification, leaving the function surface (and thus the JMEOS jar surface) unchanged.Verified: the generator run drops
same_bbox/contains_bbox/overlaps_bbox(0 registrations) while the baresame/contains/overlapsare retained, andmvn generate-sources test-compileis clean.