Build the libmeos dependency image with all MEOS families via -DALL#190
Open
estebanzimanyi wants to merge 1 commit into
Open
Build the libmeos dependency image with all MEOS families via -DALL#190estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
The dependency image built libmeos with only `-DMEOS=ON`, so the NES MEOS operators linked against a single-family libmeos that does not match the full surface built in CI elsewhere in the ecosystem. Build it with `-DALL=ON` instead, mirroring the shared provision-meos recipe used by the other MobilityDB bindings, so every optional family (CBUFFER, NPOINT, POSE, RGEO, QUADBIN, H3, POINTCLOUD, RASTER, ...) is present. - Add the family build dependencies (libh3-dev, libgdal-dev, zlib1g-dev, autoconf/automake/libtool/pkg-config); libxml2-dev was already present. - POINTCLOUD builds without PostgreSQL as of MobilityDB #1370 (cmake pointcloud_libpc over libxml2+zlib), so no PGDG/pg_config is needed. - Pin the MobilityDB checkout to an upstream master commit for a reproducible dependency image instead of a floating branch. Verified locally: `cmake -DMEOS=ON -DALL=ON` builds libmeos.so cleanly with symbols for every family (h3, quadbin, npoint, cbuffer, pose, rgeo, trgeometry, raster/raquet, pointcloud/pcpoint).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The dependency image (
docker/dependency/Base.dockerfile) built libmeos with only-DMEOS=ON, so the NES MEOS operators linked against a single-family libmeos. This builds it with-DALL=ONinstead, so every optional MEOS family (CBUFFER, NPOINT, POSE, RGEO, QUADBIN, H3, POINTCLOUD, RASTER, …) is present — matching the all-families libmeos the rest of the MobilityDB binding ecosystem builds.Changes
-DMEOS=ON→-DMEOS=ON -DALL=ONin the MobilityDB build step.libh3-dev,libgdal-dev,zlib1g-dev,autoconf,automake,libtool,pkg-config(libxml2-devwas already present).mastercommit for a reproducible dependency image instead of a floating branch.Notes
pointcloud_libpcstatic lib over libxml2 + zlib), so no PGDG/pg_configprovisioning is needed.docker/dependency/changes the dependency-image hash (hash_dependencies.sh), so CI rebuilds the image and exercises this build.Verification
Locally,
cmake -DMEOS=ON -DALL=ONon the pinned commit buildslibmeos.socleanly, with exported symbols for every family (h3, quadbin, npoint, cbuffer, pose, rgeo, trgeometry, raster/raquet, pointcloud/pcpoint).